c# - checking each char in string is outputted in wrong order?

Question

im trying to split a string into a chars(which i have semi done) and use each char to compare it to my dictionary full of random strings, and then add that chars value in the dictionary to a finished string. the problem is what its outputting- the chars are not in order.

ex: USER INPUT: "hello"---

ex: CONSOLE: "e"-"l"-"l"-"o"-"h"

thats what happens mostly. any answer as to how i can get it to spell it correctly in the console?

Code:

private void complete_text_Click(object sender, RoutedEventArgs e)
{
    end_result = input_box.Text.ToString();
    string end_translated_result = "";
    for (int i = 0; i < ZENOX_LANGUAGE.Keys.Count; i ++)
    {

        foreach (char iq in end_result.ToCharArray())
        {
            
            
            if (iq.ToString().ToLower() == ZENOX_LANGUAGE.Keys.ElementAt(i).ToString().ToLower())
            {
                Console.WriteLine(iq);
                end_translated_result += ZENOX_LANGUAGE.Values.ElementAt(i) + " ";
                
                //Console.WriteLine("sender: " + sender.ToString() + " c: " + end_result[iq].ToString().ToLower() + " s:" + ZENOX_LANGUAGE.Keys.ElementAt(i));
               Console.WriteLine("end translated result: " + end_result);
                
            }
            
        }
    }
}

Answer 1

As it stands, the order of keys in your dictionary will influence the order that output appears, because you're doing:

foreach(var k in dictionary.Keys)
  foreach(char c in someString)
    if(c == k) 
      Console.Write(c)

And dictionary keys have no defined order.

Swapping the loops over will mean (as long as the dictionary has the key you're looking for, as it's a condition that leads to printing the char) that the output will appear in order of chars in the string..

..but I can't actually work out why you enumerate the keys and then run a loop looking for the character. I'd just loop over the string and use the char to index the dictionary if I was building some sort of translator map:

var map = new Dictionary<char, char>() {
  { 'h', 'Z' }, 
  { 'e', 'Y' }, 
  { 'l', 'X' }, 
  { 'o', 'W' } 
};

var toTrans = "hello";
foreach(char c in toTrans)
  Console.Write(map[c]);

This will print "ZYXXW" for an input of "hello";

If you're mapping chars to strings, with case insensitivity it's as simple as:

var map = new Dictionary<char, string>() {
  { 'h', "Z0" }, 
  { 'e', "Y0" }, 
  { 'l', "X0" }, 
  { 'o', "W0" } 
};

var toTrans = "HelLO";
foreach(char c in toTrans)
  Console.Write(map[Char.ToLower(c)]);

This will print "Z0Y0X0X0W0"